Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require that happens_after is not mutable #866

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

kaushikcfd
Copy link
Collaborator

Closes #865.

Given that happens_after is a sufficiently big change, I suggest we release a new version.

@kaushikcfd
Copy link
Collaborator Author

Looks like this patch broke our persistent caching mechanism. I am also getting CollisionWarnings locally. Looking into it.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

cc @a-alveyblanc

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

The test failures in tutorial.rst should subside as soon as isl 0.27 enters conda-forge: conda-forge/isl-feedstock#32.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

Unless we expect the dictionaries to extensively rewritten, immutabledict is (1) far cheaper and (2) predictably ordered.

@matthiasdiener did some benchmarks at some point.

@kaushikcfd
Copy link
Collaborator Author

should subside as soon as isl 0.27 enters conda-forge

Thanks! :D

@kaushikcfd
Copy link
Collaborator Author

Unless we expect the dictionaries to extensively rewritten, immutabledict is (1) far cheaper and (2) predictably ordered.

Sg! I'll switch over to it.

@inducer
Copy link
Owner

inducer commented Sep 8, 2024

The test failures in tutorial.rst should subside as soon as isl 0.27 enters conda-forge: conda-forge/isl-feedstock#32.

I lied. This needs an islpy rebuild, too: conda-forge/islpy-feedstock#55

@inducer inducer enabled auto-merge (squash) September 9, 2024 19:35
@inducer
Copy link
Owner

inducer commented Sep 9, 2024

Thanks!

@inducer inducer merged commit 070df9f into main Sep 9, 2024
18 checks passed
@inducer inducer deleted the fix_happens_after_type branch September 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HEAD is breaking back-compat wrt loopy==2024.1
2 participants